Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Jeff King
On Fri, Feb 22, 2013 at 08:47:39AM -0800, Junio C Hamano wrote: > Jeff King writes: > > >> ... ... > >> +} > > > > Nice, I'm glad you handled this case properly. I've wondered if we > > should have an option to do a similar test when writing out the "real" > > message format. I.e., to put the e

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Junio C Hamano
Jeff King writes: >> ... ... >> +} > > Nice, I'm glad you handled this case properly. I've wondered if we > should have an option to do a similar test when writing out the "real" > message format. I.e., to put the extra "From" line in the body of the > message when !is_current_user(). Traditiona

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-22 Thread Adam Spiers
On Thu, Feb 21, 2013 at 06:13:28PM -0500, Jeff King wrote: > On Thu, Feb 21, 2013 at 12:26:22PM -0800, Junio C Hamano wrote: > > > Some people may find it convenient to append a simple patch at the > > bottom of a discussion e-mail separated by a "scissors" mark, ready > > to be applied with "git

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >>> @@ -421,6 +443,9 @@ void pp_user_info(const struct pretty_print_context *pp, >>> if (pp->mailmap) >>> map_user(pp->mailmap, &mailbuf, &maillen, &namebuf, &namelen); >>> >>> + if (pp->inline_single && is_current_user(pp, mailbuf

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Junio C Hamano
Jeff King writes: >> @@ -421,6 +443,9 @@ void pp_user_info(const struct pretty_print_context *pp, >> if (pp->mailmap) >> map_user(pp->mailmap, &mailbuf, &maillen, &namebuf, &namelen); >> >> +if (pp->inline_single && is_current_user(pp, mailbuf, maillen, namebuf, >> namele

Re: [PATCH 2/2] format-patch: --inline-single

2013-02-21 Thread Jeff King
On Thu, Feb 21, 2013 at 12:26:22PM -0800, Junio C Hamano wrote: > Some people may find it convenient to append a simple patch at the > bottom of a discussion e-mail separated by a "scissors" mark, ready > to be applied with "git am -c". Introduce "--inline-single" option > to format-patch to do s