Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-28 Thread Junio C Hamano
Ramsay Jones writes: >> However, I'm not sure about the authorship and taking credit for the >> patch. We ended up taking my patch, sure, but I think Ramsay did all >> the real hard work, i.e. writing the commit message and, most >> importantly, realizing that

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-28 Thread Ramsay Jones
On 28/02/18 00:42, SZEDER Gábor wrote: > On Wed, Feb 28, 2018 at 12:47 AM, Ramsay Jones > wrote: >> >> >> On 27/02/18 22:05, Junio C Hamano wrote: >>> Junio C Hamano writes: >>> OK, somehow I had the version from Ramsay on a topic branch

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-27 Thread SZEDER Gábor
On Wed, Feb 28, 2018 at 12:47 AM, Ramsay Jones wrote: > > > On 27/02/18 22:05, Junio C Hamano wrote: >> Junio C Hamano writes: >> >>> OK, somehow I had the version from Ramsay on a topic branch that was >>> not merged to 'pu'. Here is the

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-27 Thread Ramsay Jones
On 27/02/18 22:05, Junio C Hamano wrote: > Junio C Hamano writes: > >> OK, somehow I had the version from Ramsay on a topic branch that was >> not merged to 'pu'. Here is the replacement for 2/2 I'd be queuing. >> >> We'd need SZEDER to sign it off (optionally correcting

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-27 Thread Junio C Hamano
Junio C Hamano writes: > OK, somehow I had the version from Ramsay on a topic branch that was > not merged to 'pu'. Here is the replacement for 2/2 I'd be queuing. > > We'd need SZEDER to sign it off (optionally correcting mistakes in > the log message) if we are going with

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-27 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > >> If I understand Gábor's patch correctly, it is using test_i18ngrep for >> the specific lines we care about so that we don't have to worry about >> other cruft lines that may or may not appear (including the hangup

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-13 Thread Junio C Hamano
Jeff King writes: > If I understand Gábor's patch correctly, it is using test_i18ngrep for > the specific lines we care about so that we don't have to worry about > other cruft lines that may or may not appear (including the hangup one). > > The downside is that we would not

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-13 Thread Jeff King
On Tue, Feb 13, 2018 at 09:08:44AM -0800, Junio C Hamano wrote: > SZEDER Gábor writes: > > > A third possible fix, which is also in the "we don't care about the > > order of multiple warning messages" camp and has a nice looking > > diffstat, would be something like this:

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-13 Thread Junio C Hamano
SZEDER Gábor writes: > A third possible fix, which is also in the "we don't care about the > order of multiple warning messages" camp and has a nice looking > diffstat, would be something like this: Hmph, we are running a "git fetch" locally and observing the error output

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-13 Thread SZEDER Gábor
> > I must admit that I didn't think about the effect of the useless > > "| sort" on the exit status! What I saw was: a process that > > received no input, sorted nothing and produced no output - pretty > > much the definition of useless! ;-) > > I am not sure what you mean by "receive no input,

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-12 Thread Junio C Hamano
Ramsay Jones writes: > I must admit that I didn't think about the effect of the useless > "| sort" on the exit status! What I saw was: a process that > received no input, sorted nothing and produced no output - pretty > much the definition of useless! ;-) I am not

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-12 Thread Ramsay Jones
On 12/02/18 20:18, Junio C Hamano wrote: > Ramsay Jones writes: > >> Attempting to grep the output of test_i18ngrep will not work under a >> poison build, since the output is (almost) guaranteed not to have the >> string you are looking for. In this case, the

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-12 Thread Junio C Hamano
Junio C Hamano writes: >> -test_i18ngrep -E '^(fatal|warning):' actual >> | sort && >> +grep -E '^(fatal|warning):' actual && >> test_i18ncmp expected actual > > OK, but not quite OK. > > Two grep invocations will not leave anything useful in 'actual' > under

Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep

2018-02-12 Thread Junio C Hamano
Ramsay Jones writes: > Attempting to grep the output of test_i18ngrep will not work under a > poison build, since the output is (almost) guaranteed not to have the > string you are looking for. In this case, the output of test_i18ngrep > is further filtered by a