Re: [PATCH 2/3] read-cache: use get_be32 instead of hand-rolled ntoh_l

2014-01-23 Thread Jeff King
On Thu, Jan 23, 2014 at 03:34:16PM -0800, Jonathan Nieder wrote: > Line 1484 looks more problematic: > > disk_ce = (struct ondisk_cache_entry *)((char *)mmap + > src_offset); > > In v4 indexes, src_offset doesn't have any particular alignment so > this conversion has undefined beh

Re: [PATCH 2/3] read-cache: use get_be32 instead of hand-rolled ntoh_l

2014-01-23 Thread Jonathan Nieder
Jeff King wrote: > This _might_ still suffer from the issue fixed in 5f6a112 (block-sha1: > avoid pointer conversion that violates alignment constraints, > 2012-07-22), as we are taking the pointer of a uint32 in a struct. No conversion, so no issue there. Line 1484 looks more problematic: