Re: [PATCH 2/4] remote-helpers: rename tests

2013-05-29 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: I do not see how it makes sense to copy how they deviate from us back to our codebase, especially if we plan to eventually move some of these tests out of contrib/ area, but even without such a plan in the future. They deviate from us, we

Re: [PATCH 2/4] remote-helpers: rename tests

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: I do not see how it makes sense to copy how they deviate from us back to our codebase, especially if we plan to eventually move some of these tests out of contrib/

Re: [PATCH 2/4] remote-helpers: rename tests

2013-05-29 Thread Felipe Contreras
On Wed, May 29, 2013 at 1:44 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: On Wed, May 29, 2013 at 12:14 PM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: I do not see how it makes sense to copy

Re: [PATCH 2/4] remote-helpers: rename tests

2013-05-28 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: The .t extension is more standard for sharness tests. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Is that sharness test the sh script testsuite forked from our testsuite? I do not see how it makes sense to copy how they

Re: [PATCH 2/4] remote-helpers: rename tests

2013-05-28 Thread Felipe Contreras
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: The .t extension is more standard for sharness tests. Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- Is that sharness test the sh script testsuite forked from our testsuite? I do not see how