Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

2014-06-13 Thread Heiko Voigt
On Thu, Jun 12, 2014 at 02:58:20PM -0700, Junio C Hamano wrote: > Heiko Voigt writes: > > > ... > > +static int is_cache_init = 0; > > Please don't initialise variables in the .bss to zero by hand. Ok will remove that. > > + ... > > + warning("%s:.gitmodules, multiple configurations found fo

Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

2014-06-12 Thread Junio C Hamano
Heiko Voigt writes: > ... > +static int is_cache_init = 0; Please don't initialise variables in the .bss to zero by hand. > + ... > + warning("%s:.gitmodules, multiple configurations found for " > + "submodule.%s.%s. Skipping second one!", > + commit_

Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

2014-06-10 Thread Heiko Voigt
On Sun, Jun 08, 2014 at 05:04:44AM -0400, Eric Sunshine wrote: > On Thu, Jun 5, 2014 at 2:07 AM, Heiko Voigt wrote: > > This submodule configuration cache allows us to lazily read .gitmodules > > configurations by commit into a runtime cache which can then be used to > > easily lookup values from

Re: [PATCH 2/5] implement submodule config cache for lookup of submodule names

2014-06-08 Thread Eric Sunshine
On Thu, Jun 5, 2014 at 2:07 AM, Heiko Voigt wrote: > This submodule configuration cache allows us to lazily read .gitmodules > configurations by commit into a runtime cache which can then be used to > easily lookup values from it. Currently only the values for path or name > are stored but it can