Re: [PATCH 2/5] interpret-trailers: add an option to show only the trailers

2017-08-10 Thread Jeff King
On Wed, Aug 09, 2017 at 11:35:27AM -0700, Jonathan Tan wrote: > > -static void print_all(FILE *outfile, struct list_head *head, int > > trim_empty) > > +static void print_all(FILE *outfile, struct list_head *head, > > + struct process_trailer_options *opts) > > This can be

Re: [PATCH 2/5] interpret-trailers: add an option to show only the trailers

2017-08-09 Thread Jonathan Tan
On Wed, 9 Aug 2017 08:24:03 -0400 Jeff King wrote: > diff --git a/trailer.c b/trailer.c > index 0a0c2c264d..a4ff99f98a 100644 > --- a/trailer.c > +++ b/trailer.c > @@ -164,13 +164,15 @@ static void print_tok_val(FILE *outfile, const char > *tok, const char *val) >

Re: [PATCH 2/5] interpret-trailers: add an option to show only the trailers

2017-08-09 Thread Stefan Beller
On Wed, Aug 9, 2017 at 10:52 AM, Stefan Beller wrote: > On Wed, Aug 9, 2017 at 5:24 AM, Jeff King wrote: >> In theory it's easy for any reader who wants to parse >> trailers to do so. But there are a lot of subtle corner >> cases around what counts as a

Re: [PATCH 2/5] interpret-trailers: add an option to show only the trailers

2017-08-09 Thread Stefan Beller
On Wed, Aug 9, 2017 at 5:24 AM, Jeff King wrote: > In theory it's easy for any reader who wants to parse > trailers to do so. But there are a lot of subtle corner > cases around what counts as a trailer, when the trailer > block begins and ends, etc. Since interpret-trailers