Re: [PATCH 2/5] prune --repos: fix uninitialized access

2014-07-24 Thread Duy Nguyen
On Thu, Jul 24, 2014 at 2:59 AM, Junio C Hamano wrote: > It does not explain what the change to the test is about, though. The old test and code are wrong. We want to verify repos are not pruned if they're new (like, just created). But "git prune" without --expire sets expire time to 0x (

Re: [PATCH 2/5] prune --repos: fix uninitialized access

2014-07-23 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > There's a code path in prune_repo_dir() that does not initialize 'st' > buffer, which is checked by the caller, prune_repos_dir(). Instead > of leaking some prune logic out to prune_repos_dir(), move 'st' into > prune_repo_dir(). > > Signed-off-by: Nguyễn Thái Ngọc