Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-24 Thread Eric Sunshine
On Wed, Jul 24, 2013 at 11:10 AM, Junio C Hamano wrote: > Eric Sunshine writes: > >> On Tue, Jul 23, 2013 at 3:03 PM, Junio C Hamano wrote: >>> SZEDER Gábor writes: You could avoid the 'cat' here and patch in 4/5 by doing $(wc -l >> Correct. >> >> Thanks, I like that better. >> >> Unfortun

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-24 Thread Junio C Hamano
Eric Sunshine writes: > On Tue, Jul 23, 2013 at 3:03 PM, Junio C Hamano wrote: >> SZEDER Gábor writes: >>> You could avoid the 'cat' here and patch in 4/5 by doing $(wc -l > Correct. > > Thanks, I like that better. > > Unfortunately, what actually got queued on 'next', after applying this > fix

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-23 Thread Eric Sunshine
On Tue, Jul 23, 2013 at 3:03 PM, Junio C Hamano wrote: > SZEDER Gábor writes: >> You could avoid the 'cat' here and patch in 4/5 by doing $(wc -l Correct. Thanks, I like that better. Unfortunately, what actually got queued on 'next', after applying this fix-up and re-ordering the patch series,

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-23 Thread SZEDER Gábor
On Tue, Jul 23, 2013 at 12:03:05PM -0700, Junio C Hamano wrote: > SZEDER Gábor writes: > > (Side question: the test suite is full with similar constructs, i.e. > > redirecting file contents to stdin, but why not just use wc -l b.c, > > i.e. let wc open the file?) > > "wc -l otherwise you will se

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-23 Thread Junio C Hamano
SZEDER Gábor writes: > You could avoid the 'cat' here and patch in 4/5 by doing $(wc -l (Side question: the test suite is full with similar constructs, i.e. > redirecting file contents to stdin, but why not just use wc -l b.c, > i.e. let wc open the file?) "wc -l http://vger.kernel.org/majordom

Re: [PATCH 2/5] t4211: demonstrate empty -L range crash

2013-07-23 Thread SZEDER Gábor
On Tue, Jul 23, 2013 at 10:28:05AM -0400, Eric Sunshine wrote: > Signed-off-by: Eric Sunshine > --- > t/t4211-line-log.sh | 8 > 1 file changed, 8 insertions(+) > > diff --git a/t/t4211-line-log.sh b/t/t4211-line-log.sh > index 7776f93..1db1edd 100755 > --- a/t/t4211-line-log.sh > +++ b