Re: [PATCH 2/6] fixup! fixup! fixup! Change 'git' to 'Git' whenever the whole system is referred to #1

2013-02-01 Thread Junio C Hamano
Jonathan Nieder  writes:

>> diff --git a/Documentation/git-rev-parse.txt 
>> b/Documentation/git-rev-parse.txt
>> index c743469..14386ed 100644
>> --- a/Documentation/git-rev-parse.txt
>> +++ b/Documentation/git-rev-parse.txt
>> @@ -187,9 +187,9 @@ print a message to stderr and exit with nonzero status.
>>  Flags and parameters to be parsed.
>>  
>>  --resolve-git-dir ::
>> -Check if  is a valid git-dir or a git-file pointing to a valid
>> -git-dir. If  is a valid git-dir the resolved path to git-dir will
>> -be printed.
>> +Check if  is a valid `$GIT_DIR` or a gitfile pointing to a valid
>> +`$GIT_DIR`. If  is a valid `$GIT_DIR` the resolved path to 
>> `$GIT_DIR`
>> +will be printed.
>
> Hm, I don't find the old or the new version very easy to understand.  Perhaps 
> the
> idea is something like this?
>
>   Check if  is a valid git repository (.git or .git
>   directory) or "gitdir:" file.  If  is a "gitdir:" file
>   then the resolved path to the corresponding real git repository
>   will be printed.

Yeah, sounds much better.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 2/6] fixup! fixup! fixup! Change 'git' to 'Git' whenever the whole system is referred to #1

2013-02-01 Thread Jonathan Nieder
Hi,

Thomas Ackermann wrote:

> Found by Junio:
> Change git-dir to $GIT_DIR and git-file to gitfile.
>
> Signed-off-by: Thomas Ackermann 
> ---
>  Documentation/git-rev-parse.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/git-rev-parse.txt b/Documentation/git-rev-parse.txt
> index c743469..14386ed 100644
> --- a/Documentation/git-rev-parse.txt
> +++ b/Documentation/git-rev-parse.txt
> @@ -187,9 +187,9 @@ print a message to stderr and exit with nonzero status.
>   Flags and parameters to be parsed.
>  
>  --resolve-git-dir ::
> - Check if  is a valid git-dir or a git-file pointing to a valid
> - git-dir. If  is a valid git-dir the resolved path to git-dir will
> - be printed.
> + Check if  is a valid `$GIT_DIR` or a gitfile pointing to a valid
> + `$GIT_DIR`. If  is a valid `$GIT_DIR` the resolved path to 
> `$GIT_DIR`
> + will be printed.

Hm, I don't find the old or the new version very easy to understand.  Perhaps 
the
idea is something like this?

Check if  is a valid git repository (.git or .git
directory) or "gitdir:" file.  If  is a "gitdir:" file
then the resolved path to the corresponding real git repository
will be printed.

Thanks,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html