Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-11 Thread Johannes Schindelin
Hi Kuba, On Fri, 9 Sep 2016, Jakub Narębski wrote: > W dniu 09.09.2016 o 16:40, Johannes Schindelin napisał: > > On Fri, 2 Sep 2016, Jakub Narębski wrote: > >> W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze: > >>> On Thu, 1 Sep 2016, Jakub Narębski wrote: > W dniu 29.08.2016 o 10:06,

Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-09 Thread Jakub Narębski
Hello Johannes, W dniu 09.09.2016 o 16:40, Johannes Schindelin napisał: > On Fri, 2 Sep 2016, Jakub Narębski wrote: >> W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze: >>> On Thu, 1 Sep 2016, Jakub Narębski wrote: W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze: >> > if (comm

Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-09 Thread Johannes Schindelin
Hi Kuba, On Fri, 2 Sep 2016, Jakub Narębski wrote: > W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze: > > On Thu, 1 Sep 2016, Jakub Narębski wrote: > >> W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze: > > >>> if (commit_lock_file(&msg_file) < 0) > >>> return error(_("Erro

Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-01 Thread Jakub Narębski
Hello Johannes, W dniu 01.09.2016 o 16:20, Johannes Schindelin pisze: > On Thu, 1 Sep 2016, Jakub Narębski wrote: >> W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze: >>> if (commit_lock_file(&msg_file) < 0) >>> return error(_("Error wrapping up %s."), filename); >> >> Anothe

Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-01 Thread Johannes Schindelin
Hi Kuba, On Thu, 1 Sep 2016, Jakub Narębski wrote: > W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze: > > > The write_message() function safely writes an strbuf to a file. > > Sometimes this is inconvenient, though: the text to be written may not > > be stored in a strbuf, or the strbuf sho

Re: [PATCH 22/22] sequencer: refactor write_message()

2016-09-01 Thread Jakub Narębski
Hello Johannes, W dniu 29.08.2016 o 10:06, Johannes Schindelin pisze: > The write_message() function safely writes an strbuf to a file. > Sometimes this is inconvenient, though: the text to be written may not > be stored in a strbuf, or the strbuf should not be released after > writing. By "this