Re: [PATCH 3/3] ref-filter: factor ref_array pushing into its own function

On Mon, Apr 09, 2018 at 08:18:35AM +0900, Junio C Hamano wrote: > Jeff King writes: > > > In preparation for callers constructing their own ref_array > > structs, let's move our own internal push operation into its > > own function. > > > > While we're at it, we can replace

Re: [PATCH 3/3] ref-filter: factor ref_array pushing into its own function

Jeff King writes: > In preparation for callers constructing their own ref_array > structs, let's move our own internal push operation into its > own function. > > While we're at it, we can replace REALLOC_ARRAY() with > ALLOC_GROW(), which should give the growth operation >

Re: [PATCH 3/3] ref-filter: factor ref_array pushing into its own function

Looks good to me. Reviewed-by: Harald Nordgren On Fri, Apr 6, 2018 at 9:27 PM, Derrick Stolee wrote: > On 4/6/2018 2:59 PM, Jeff King wrote: >> >> In preparation for callers constructing their own ref_array >> structs, let's move our own internal

Re: [PATCH 3/3] ref-filter: factor ref_array pushing into its own function

On 4/6/2018 2:59 PM, Jeff King wrote: In preparation for callers constructing their own ref_array structs, let's move our own internal push operation into its own function. While we're at it, we can replace REALLOC_ARRAY() with ALLOC_GROW(), which should give the growth operation amortized