Re: [PATCH 3/4] Fix misuses of nor in comments. (v3)
On Sat, Mar 29, 2014 at 6:59 PM, Justin Lebar jle...@google.com wrote: This version applies successfully to master, maint, next, and pu. The other patches in the previous version of this queue apply successfully without any changes. Signed-off-by: Justin Lebar jle...@google.com --- Makefile| 2 +- builtin/apply.c | 2 +- builtin/checkout.c | 2 +- builtin/log.c | 2 +- builtin/pack-objects.c | 2 +- column.c| 4 ++-- contrib/examples/git-checkout.sh| 2 +- contrib/examples/git-reset.sh | 4 ++-- contrib/fast-import/import-directories.perl | 4 ++-- delta.h | 2 +- diff.c | 2 +- git-am.sh | 2 +- gitweb/gitweb.perl | 2 +- http.h | 4 ++-- perl/Git/SVN.pm | 2 +- perl/Git/SVN/Migration.pm | 2 +- pkt-line.h | 8 remote.c| 2 +- sha1_file.c | 2 +- test-chmtime.c | 2 +- 20 files changed, 27 insertions(+), 27 deletions(-) snip diff --git a/http.h b/http.h index cd37d58..0a7d286 100644 --- a/http.h +++ b/http.h @@ -13,8 +13,8 @@ /* * We detect based on the cURL version if multi-transfer is * usable in this implementation and define this symbol accordingly. - * This is not something Makefile should set nor users should pass - * via CFLAGS. + * This shouldn't be be set by the Makefile or by the user (e.g. via + * CFLAGS). */ #undef USE_CURL_MULTI There's a rather minor typo here: be be Jason -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] Fix misuses of nor in comments. (v3)
Thanks; fixed in v4 (just sent out). On Mon, Mar 31, 2014 at 12:54 PM, Jason St. John jstj...@purdue.edu wrote: On Sat, Mar 29, 2014 at 6:59 PM, Justin Lebar jle...@google.com wrote: This version applies successfully to master, maint, next, and pu. The other patches in the previous version of this queue apply successfully without any changes. Signed-off-by: Justin Lebar jle...@google.com --- Makefile| 2 +- builtin/apply.c | 2 +- builtin/checkout.c | 2 +- builtin/log.c | 2 +- builtin/pack-objects.c | 2 +- column.c| 4 ++-- contrib/examples/git-checkout.sh| 2 +- contrib/examples/git-reset.sh | 4 ++-- contrib/fast-import/import-directories.perl | 4 ++-- delta.h | 2 +- diff.c | 2 +- git-am.sh | 2 +- gitweb/gitweb.perl | 2 +- http.h | 4 ++-- perl/Git/SVN.pm | 2 +- perl/Git/SVN/Migration.pm | 2 +- pkt-line.h | 8 remote.c| 2 +- sha1_file.c | 2 +- test-chmtime.c | 2 +- 20 files changed, 27 insertions(+), 27 deletions(-) snip diff --git a/http.h b/http.h index cd37d58..0a7d286 100644 --- a/http.h +++ b/http.h @@ -13,8 +13,8 @@ /* * We detect based on the cURL version if multi-transfer is * usable in this implementation and define this symbol accordingly. - * This is not something Makefile should set nor users should pass - * via CFLAGS. + * This shouldn't be be set by the Makefile or by the user (e.g. via + * CFLAGS). */ #undef USE_CURL_MULTI There's a rather minor typo here: be be Jason -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/4] Fix misuses of nor in comments. (v3)
Justin Lebar jle...@google.com writes:
Thanks; fixed in v4 (just sent out).
I only saw [3/4] that was marked with (v3) at the end, without
[{1,2,4}/4]. As you seem to be renumbering from the very original
(which had l10n at number 3), only sending out what you changed,
expecting that everybody else knows what you are doing, is not very
friendly to anybody who is trying not to lose patches in all the
other activities on the list. Also people who haven't seen the
older iterations do not have to fish them from the archive if you
repost the whole thing.
Please use format-patch -v5 (or whatever numbering) so that the
series iteration number is inside, e.g. [PATCH v5 1/6].
Thanks.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
