Re: [PATCH 3/4] Makefile: factor common configuration in git-default-config.mak

2013-02-08 Thread Matthieu Moy 
Junio C Hamano gits...@pobox.com writes:

 I really think this is going in a wrong direction.  Whatever you
 happen to have chosen in this patch will be available to others,
 while whatever are left out will not be.  When adding new things,
 people need to ask if it needs to be sharable or not, and the right
 answer to that question will even change over time.

My feeling is that Git's toplevel Makefile has become too large to
remain completely monolithic, and splitting is good to organize it (and
yes, splitting code into several files imply that future added code will
have to be added in the right file, but that's not very different from
splitting C code into several .c files to me). But that is another
matter, and ...

Junio C Hamano gits...@pobox.com writes:

 Then do something like

   all::
   $(MAKE) -C ../.. \
   PERL_SCRIPT=contrib/mw-to-git/git-remote-mediawiki.perl 
 \
 build-perl-script

This ended up being very simple to implement (essentially, the Makefile
already knows how to do this, so this just means adding convenience
build-perl-script target to the toplevel), so 2 new patches follow doing
this, with a ridiculously small new version of mw-to-git/Makefile.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] Makefile: factor common configuration in git-default-config.mak

2013-02-07 Thread Junio C Hamano 
Matthieu Moy matthieu@imag.fr writes:

 Similarly to the extraction of perl-related code in perl.mak, we extract
 general default configuration from the Makefile to make it available from
 directories other than the toplevel.

 This is required to make perl.mak usable because it requires $(pathsep)
 to be set.

 Signed-off-by: Matthieu Moy matthieu@imag.fr
 ---

I really think this is going in a wrong direction.  Whatever you
happen to have chosen in this patch will be available to others,
while whatever are left out will not be.  When adding new things,
people need to ask if it needs to be sharable or not, and the right
answer to that question will even change over time.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html