Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset
Jakub Narębski jna...@gmail.com wrote: On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch d...@dotat.at wrote: On the repository summary page, leave the whole owner line out if the repo does not have an owner, rather than displaying a labelled empty field.. Note that if $omit_owner is true, whole _column_ is skipped. There are two places where the owner is displayed: on the list of projects, and on each project's summary page. This change affects the summary page (where it removes a row, not a column) and it leaves the projects list alone. I'll make that clearer in the commit message (and fix the extraneous dot). Tony. -- f.anthony.n.finch d...@dotat.at http://dotat.at/ Forties, Cromarty: East, veering southeast, 4 or 5, occasionally 6 at first. Rough, becoming slight or moderate. Showers, rain at first. Moderate or good, occasionally poor at first.
Re: [PATCH 3/4] gitweb: omit the repository owner when it is unset
On Tue, Jul 2, 2013 at 6:24 PM, Tony Finch d...@dotat.at wrote:
On the repository summary page, leave the whole owner line out if
the repo does not have an owner, rather than displaying a labelled
empty field..
Note that if $omit_owner is true, whole _column_ is skipped.
Is removing cell (instead of leaving it empty) and relying on browser
treating nonexistent cell correctly a good idea, that I do not know.
Does it looks better? Does it looks better in all web browsers?
Signed-off-by: Tony Finch d...@dotat.at
---
gitweb/gitweb.perl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 8d69ada..c029b98 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -6463,7 +6463,7 @@ sub git_summary {
print div class=\title\nbsp;/div\n;
print table class=\projects_list\\n .
tr id=\metadata_desc\tddescription/tdtd .
esc_html($descr) . /td/tr\n;
-unless ($omit_owner) {
+if ($owner and not $omit_owner) {
print tr id=\metadata_owner\tdowner/tdtd .
esc_html($owner) . /td/tr\n;
}
if (defined $cd{'rfc2822'}) {
--
1.8.3.1.605.g85318f5
--
Jakub Narebski
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
