Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 02:36:41PM +0200, Mischa POSLAWSKY wrote: > Jeff King wrote: > > -#if LIBCURL_VERSION_NUM >= 0x071301 > > curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL); > > -#elif LIBCURL_VERSION_NUM >= 0x071101 > > curl_easy_setopt(result, CURLOPT_POST301, 1);

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-10 Thread Mischa POSLAWSKY
Jeff King wrote: > -#if LIBCURL_VERSION_NUM >= 0x071301 > curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL); > -#elif LIBCURL_VERSION_NUM >= 0x071101 > curl_easy_setopt(result, CURLOPT_POST301, 1); > -#endif This seems to be an unintended behavioural change: the second

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 10:34:09AM -0700, Stefan Beller wrote: > On Wed, Aug 9, 2017 at 5:02 AM, Jeff King wrote: > > Since v2.12.0, Git does not compile with versions of curl > > older than 7.19.4. That version of curl is about 8 years > > old. This means it may still be used in

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-09 Thread Stefan Beller
On Wed, Aug 9, 2017 at 5:02 AM, Jeff King wrote: > Since v2.12.0, Git does not compile with versions of curl > older than 7.19.4. That version of curl is about 8 years > old. This means it may still be used in some distributions > with long-running support periods. But the fact

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-09 Thread Jeff King
On Wed, Aug 09, 2017 at 03:14:22PM +0200, Ævar Arnfjörð Bjarmason wrote: > This whole series looks good to me. As I commented on in the thread you > referenced in 0/4 I think this is the right trade-off, and people like > me who occasionally compile git on older systems can just easily package >

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-09 Thread Ævar Arnfjörð Bjarmason
On Wed, Aug 09 2017, Jeff King jotted: > Since v2.12.0, Git does not compile with versions of curl > older than 7.19.4. That version of curl is about 8 years > old. This means it may still be used in some distributions > with long-running support periods. But the fact that we > haven't received