Re: [PATCH 3/4] t4014: do not uese echo -n

[Brandon Casey]

On Tue, Jan 1, 2013 at 5:16 PM, Junio C Hamano  wrote:
> Torsten Bögershausen  writes:
>
>> echo -n is not portable on all systems.
>> Use printf instead
>>
>> Signed-off-by: Torsten Bögershausen 
>> ---
>
> Brandon, this comes from 932581b (Unify appending signoff in
> format-patch, commit and sequencer, 2012-11-25).  Please make sure
> to squash it in when you reroll the series.

Will do.

> Thanks (and a happy new year ;-).

Thanks.  Happy New Year to you too. :)

-Brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] t4014: do not uese echo -n

[Junio C Hamano]

Torsten Bögershausen  writes:

> echo -n is not portable on all systems.
> Use printf instead
>
> Signed-off-by: Torsten Bögershausen 
> ---

Brandon, this comes from 932581b (Unify appending signoff in
format-patch, commit and sequencer, 2012-11-25).  Please make sure
to squash it in when you reroll the series.

Thanks (and a happy new year ;-).

>  t/t4014-format-patch.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t4014-format-patch.sh b/t/t4014-format-patch.sh
> index 6cfad13..f460930 100755
> --- a/t/t4014-format-patch.sh
> +++ b/t/t4014-format-patch.sh
> @@ -993,7 +993,7 @@ EOF
>  '
>  
>  test_expect_success 'signoff: commit with only subject that does not end 
> with NL' '
> - echo -n subject | append_signoff >actual &&
> + printf subject | append_signoff >actual &&
>   cat >expected <<\EOF &&
>  4:Subject: [PATCH] subject
>  8:
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html