Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Junio C Hamano
Jeff King writes: > Perhaps "--exact-input" hits all of those. Or maybe "--only-input" to > match the other "--only". > > I think I like that last one the best. It makes it clear that we are > looking just at the input, and not anything else. Which is exactly what > the feature

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 10:33 AM, Jeff King wrote: > On Thu, Aug 10, 2017 at 10:27:19AM -0700, Stefan Beller wrote: > >> > I'm not fond of that, as it's vague about which exact trailers we're >> > talking about. I also thought of something like --verbatim, but I'd >> > worry that

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Jeff King
On Thu, Aug 10, 2017 at 10:27:19AM -0700, Stefan Beller wrote: > > I'm not fond of that, as it's vague about which exact trailers we're > > talking about. I also thought of something like --verbatim, but I'd > > worry that would seem to conflict with --normalize. > > > > I dunno. All of the names

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Stefan Beller
On Thu, Aug 10, 2017 at 12:32 AM, Jeff King wrote: > On Wed, Aug 09, 2017 at 11:18:19AM -0700, Stefan Beller wrote: > >> On Wed, Aug 9, 2017 at 5:24 AM, Jeff King wrote: >> > It can be useful to invoke interpret-trailers for the >> > primary purpose of parsing

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Jeff King
On Wed, Aug 09, 2017 at 11:38:20AM -0700, Jonathan Tan wrote: > > diff --git a/t/t7513-interpret-trailers.sh b/t/t7513-interpret-trailers.sh > > index e5b0718ef6..525fd53e5b 100755 > > --- a/t/t7513-interpret-trailers.sh > > +++ b/t/t7513-interpret-trailers.sh > > @@ -1312,4 +1312,19 @@

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-10 Thread Jeff King
On Wed, Aug 09, 2017 at 11:18:19AM -0700, Stefan Beller wrote: > On Wed, Aug 9, 2017 at 5:24 AM, Jeff King wrote: > > It can be useful to invoke interpret-trailers for the > > primary purpose of parsing existing trailers. But in that > > case, we don't want to apply existing

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-09 Thread Jonathan Tan
On Wed, 9 Aug 2017 08:24:40 -0400 Jeff King wrote: > diff --git a/t/t7513-interpret-trailers.sh b/t/t7513-interpret-trailers.sh > index e5b0718ef6..525fd53e5b 100755 > --- a/t/t7513-interpret-trailers.sh > +++ b/t/t7513-interpret-trailers.sh > @@ -1312,4 +1312,19 @@

Re: [PATCH 3/5] interpret-trailers: add an option to show only existing trailers

2017-08-09 Thread Stefan Beller
On Wed, Aug 9, 2017 at 5:24 AM, Jeff King wrote: > It can be useful to invoke interpret-trailers for the > primary purpose of parsing existing trailers. But in that > case, we don't want to apply existing ifMissing or ifExists > rules from the config. Let's add a special mode where