Thanks. The rest all look good too.
> -Original Message-
> From: Jeff King [mailto:p...@peff.net]
> Sent: Friday, September 30, 2016 6:45 PM
> To: David Turner
> Cc: git@vger.kernel.org
> Subject: Re: [PATCH 3/6] tmp-objdir: introduce API for temporary object
> di
On Fri, Sep 30, 2016 at 09:32:04PM +, David Turner wrote:
> > +static void env_append(struct argv_array *env, const char *key, const
> > +char *val) {
> > + const char *old = getenv(key);
> > +
> > + if (!old)
> > + argv_array_pushf(env, "%s=%s", key, val);
> > + else
> > +
On Fri, Sep 30, 2016 at 02:25:43PM -0700, Junio C Hamano wrote:
> > +void add_to_alternates_internal(const char *reference)
> > +{
> > + prepare_alt_odb();
> > + link_alt_odb_entries(reference, strlen(reference), '\n', NULL, 0);
> > +}
> > +
>
> A function _internal being extern felt a bit fu
> +static void env_append(struct argv_array *env, const char *key, const
> +char *val) {
> + const char *old = getenv(key);
> +
> + if (!old)
> + argv_array_pushf(env, "%s=%s", key, val);
> + else
> + argv_array_pushf(env, "%s=%s%c%s", key, old, PATH_SEP,
> val);
Jeff King writes:
> diff --git a/sha1_file.c b/sha1_file.c
> index 9a79c19..65deaf9 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -421,6 +421,12 @@ void add_to_alternates_file(const char *reference)
> free(alts);
> }
>
> +void add_to_alternates_internal(const char *reference)
> +{
5 matches
Mail list logo