Re: [PATCH 4/4] attr.c: fix matching "subdir" without the trailing slash

2013-03-25 Thread Duy Nguyen
On Mon, Mar 25, 2013 at 02:20:31PM +0700, Duy Nguyen wrote: > On second thought, maybe we should not pass path "subdir/" at all. > Instead we create a fake dtype based on the trailing slash and pass it > down to attr.c:fill() -> path_matches(), just like how > last_exclude_matching_from_list() is c

Re: [PATCH 4/4] attr.c: fix matching "subdir" without the trailing slash

2013-03-25 Thread Duy Nguyen
On Mon, Mar 25, 2013 at 1:05 PM, Nguyễn Thái Ngọc Duy wrote: > The story goes back to 94bc671 (Add directory pattern matching to > attributes - 2012-12-08). Before this commit, directories are passed > to path_matches without the trailing slash. This is fine for matching > pattern "subdir" with "f