Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-08-06 Thread Junio C Hamano
Jeff King writes: > Two reasons: OK, both boils down to "Junio did not consider 'master:foobar' case". Thanks; it makes sense now. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-08-06 Thread Jeff King
On Tue, Aug 06, 2013 at 09:28:28AM -0700, Junio C Hamano wrote: > Jeff King writes: > > > @@ -170,6 +172,20 @@ static struct ref *get_ref_map(struct transport > > *transport, > > rm->fetch_head_status = FETCH_HEAD_MERGE; > > if (tags == TAGS_SET) > >

Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-08-06 Thread Junio C Hamano
Jeff King writes: > @@ -170,6 +172,20 @@ static struct ref *get_ref_map(struct transport > *transport, > rm->fetch_head_status = FETCH_HEAD_MERGE; > if (tags == TAGS_SET) > get_fetch_map(remote_refs, tag_refspec, &tail, 0); > + > +

Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-05-15 Thread Jeff King
On Sun, May 12, 2013 at 11:41:45AM +0200, Thomas Rast wrote: > >> We miss an opportunity to update "refs/remotes/origin/master" > >> (or whatever the user has configured). Some users find this > >> confusing, because they would want to do further comparisons > >> against the old state of the remot

Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-05-12 Thread Thomas Rast
Thomas Rast writes: > Jeff King writes: > >> When we run a regular "git fetch" without arguments, we >> update the tracking refs according to the configured >> refspec. However, when we run "git fetch origin master" (or >> "git pull origin master"), we do not look at the configured >> refspecs a

Re: [PATCH 4/4] fetch: opportunistically update tracking refs

2013-05-12 Thread Thomas Rast
Jeff King writes: > When we run a regular "git fetch" without arguments, we > update the tracking refs according to the configured > refspec. However, when we run "git fetch origin master" (or > "git pull origin master"), we do not look at the configured > refspecs at all, and just update FETCH_H