On Wed, Feb 06, 2013 at 09:47:06PM +0100, Michal Nazarewicz wrote: > From: Michal Nazarewicz <min...@mina86.com> > > If smtp_user is provided but smtp_pass is not, instead of prompting > for password, make git-send-email use git credential command > instead. > > Signed-off-by: Michal Nazarewicz <min...@mina86.com> > --- > Documentation/git-send-email.txt | 4 +-- > git-send-email.perl | 59 > +++++++++++++++++++++++----------------- > 2 files changed, 36 insertions(+), 27 deletions(-)
Nice. I don't see anything obviously wrong with the code, but I didn't try it myself. I wonder how hard it would be to have some tests in t9001. It looks like we don't test the smtp code paths at all, since we would have to implement a fake smtp server. Which probably means the answer is is "pretty hard", unless there is an easy-to-use CPAN smtp server module we can plug in. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
