On Sun, Jun 2, 2013 at 9:03 AM, Ramkumar Ramachandra wrote:
> Currently, the completion for 'git format-patch' uses
> __git_complete_revlist. Although this is technically correct, and you
> can
>
> $ git format-patch master contrib
>
> where master is a ref and contrib is a pathspec, just like in 'git log',
> the usage is unidiomatic and undocumented. 'git format-patch' is used
> without pathspec filtering most of the time, and it makes sense to
> provide sensible completions using __git_refs.
This breaks 'git format-patch master..'.
Moreover, this is a perfectly fine usage of 'git format-patch':
% git format-patch --full-diff master..fc/remote/hg-next --
contrib/remote-helpers/git-remote-bzr
Plus, even even with your patch 'contrib' will be completed regardless
(by default completion), wouldn't it?
NAK.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
