Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case
On Wed, Oct 10, 2012 at 12:31 PM, Junio C Hamano wrote: > Nguyen Thai Ngoc Duy writes: > >> Git's ctype does not seem to be complete for wildmatch's use so >> ctype.h is required. But that can be easily fixed later on. > > Until "later on", I cannot even compile the series. So that's why you noticed this patch :) It builds fine here. I'll fix up and send an update later. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case
Nguyen Thai Ngoc Duy writes: > Git's ctype does not seem to be complete for wildmatch's use so > ctype.h is required. But that can be easily fixed later on. Until "later on", I cannot even compile the series. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case
On Wed, Oct 10, 2012 at 3:47 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/wildmatch.c b/wildmatch.c >> index 7b64a6b..2382873 100644 >> --- a/wildmatch.c >> +++ b/wildmatch.c >> @@ -11,8 +11,8 @@ >> >> #include >> #include >> -#include >> >> +#include "cache.h" >> #include "wildmatch.h" > > This is wrong; the includes from the system headers should have > been removed in the previous step where the series "integrated" > wildmatch to git, after which point the first include any C source > that is not at the platform-compatibility layer should be cache.h > or git-compat-util.h. Git's ctype does not seem to be complete for wildmatch's use so ctype.h is required. But that can be easily fixed later on. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 4/8] wildmatch: remove static variable force_lower_case
Nguyễn Thái Ngọc Duy writes: > diff --git a/wildmatch.c b/wildmatch.c > index 7b64a6b..2382873 100644 > --- a/wildmatch.c > +++ b/wildmatch.c > @@ -11,8 +11,8 @@ > > #include > #include > -#include > > +#include "cache.h" > #include "wildmatch.h" This is wrong; the includes from the system headers should have been removed in the previous step where the series "integrated" wildmatch to git, after which point the first include any C source that is not at the platform-compatibility layer should be cache.h or git-compat-util.h. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
