Re: [PATCH 5/5] refs.c: make @ a pseudo-ref alias to HEAD

2013-05-01 Thread Felipe Contreras
On Wed, May 1, 2013 at 11:20 AM, Ramkumar Ramachandra artag...@gmail.com wrote: First, make sure that check_refname_format() rejects the a refname beginning with a '@'. Add a test to t1400 (update-ref) demonstrating that update-ref forbids the user from updating a ref named @. Now,

Re: [PATCH 5/5] refs.c: make @ a pseudo-ref alias to HEAD

2013-05-01 Thread Ramkumar Ramachandra
Felipe Contreras wrote: Does the user really cares if it's a pseudo-ref or not? Also, what does it mean that refers to HEAD? It's not about whether the user cares or not; it's about saying it in a way that doesn't make it less precise. I'm saying @ is like a symbolic-ref .git/@ ref referring

Re: [PATCH 5/5] refs.c: make @ a pseudo-ref alias to HEAD

2013-05-01 Thread Felipe Contreras
On Wed, May 1, 2013 at 2:00 PM, Ramkumar Ramachandra artag...@gmail.com wrote: Felipe Contreras wrote: Does the user really cares if it's a pseudo-ref or not? Also, what does it mean that refers to HEAD? It's not about whether the user cares or not; it's about saying it in a way that doesn't

Re: [PATCH 5/5] refs.c: make @ a pseudo-ref alias to HEAD

2013-05-01 Thread Ramkumar Ramachandra
Felipe Contreras wrote: If I put my user shoes, I don't care how @ is implemented, I just care that it's a shortcut for HEAD, that's what it means to me, the common user. Okay, we'll change this. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to