Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files

2012-07-19 Thread Junio C Hamano
Stefano Lattarini writes: > On 07/19/2012 08:56 AM, Matthieu Moy wrote: >> Stefano Lattarini writes: >> >>> for example, an autotools old-timer that has run: >>> >>> ./configure --prefix /opt/git >>> >>> in the past, without running "make distclean" afterwards, would >>> expect a "make inst

Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files

2012-07-19 Thread Stefano Lattarini
On 07/19/2012 09:43 AM, Matthieu Moy wrote: > Stefano Lattarini writes: > >> Should I add "Acked-by: Matthieu Moy" then? (Sorry if it's a dumb >> question, but I'm not sure which the preferred policy is around here). > > Not necessarily needed if the patch is not otherwise controversial. The >

Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files

2012-07-19 Thread Matthieu Moy
Stefano Lattarini writes: > Should I add "Acked-by: Matthieu Moy" then? (Sorry if it's a dumb > question, but I'm not sure which the preferred policy is around here). Not necessarily needed if the patch is not otherwise controversial. The email discussions are usually sufficient for that. I'd s

Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files

2012-07-19 Thread Stefano Lattarini
On 07/19/2012 08:56 AM, Matthieu Moy wrote: > Stefano Lattarini writes: > >> for example, an autotools old-timer that has run: >> >> ./configure --prefix /opt/git >> >> in the past, without running "make distclean" afterwards, would >> expect a "make install" issued after a "make clean" to re

Re: [PATCH 6/7] build: "make clean" should not remove configure-generated files

2012-07-18 Thread Matthieu Moy
Stefano Lattarini writes: > for example, an autotools old-timer that has run: > > ./configure --prefix /opt/git > > in the past, without running "make distclean" afterwards, would > expect a "make install" issued after a "make clean" to rebuild and > install git in '/opt/git'; I've been hit