Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On 2013-11-11 14:29, Felipe Contreras wrote: > On Mon, Nov 11, 2013 at 1:19 PM, Richard Hansen wrote: >> On 2013-11-11 06:42, Felipe Contreras wrote: >>> Richard Hansen wrote: It's hard to tell which author conversion test failed when the email addresses look similar. Signed-off-by: Richard Hansen --- contrib/remote-helpers/test-hg.sh | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh index 84c67ff..5eda265 100755 --- a/contrib/remote-helpers/test-hg.sh +++ b/contrib/remote-helpers/test-hg.sh @@ -209,16 +209,16 @@ test_expect_success 'authors' ' >../expected && author_test alpha "" "H G Wells " && -author_test beta "test" "test " && -author_test beta "test (comment)" "test " && >> >> Notice the two betas here in the original code. > > Ahh, that's a bug. > -author_test gamma "" "Unknown " && -author_test delta "name" "name " && -author_test epsilon "name >>> " && -author_test zeta " test " "test " && -author_test eta "test < t...@example.com >" "test " && -author_test theta "test >t...@example.com>" "test " && -author_test iota "test < test example com>" "test " && -author_test kappa "t...@example.com" "Unknown " +author_test beta "beta" "beta " && +author_test beta "beta (comment)" "beta " && >>> >>> Two betas? >> >> See above. I can change them to beta1 and beta2, or if you'd prefer I >> can change them to beta and gamma and increment the subsequent entries. > > Yeah, I would prefer that in two patches, one that fixes the sequence, > and the other one that changes the emails. Will do. Thanks, Richard > If you don't have time for > that the original patch is OK by me. The problem with the sequence can > be fixed later. > > Cheers. > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On Mon, Nov 11, 2013 at 1:19 PM, Richard Hansen wrote: > On 2013-11-11 06:42, Felipe Contreras wrote: >> Richard Hansen wrote: >>> It's hard to tell which author conversion test failed when the email >>> addresses look similar. >>> >>> Signed-off-by: Richard Hansen >>> --- >>> contrib/remote-helpers/test-hg.sh | 20 ++-- >>> 1 file changed, 10 insertions(+), 10 deletions(-) >>> >>> diff --git a/contrib/remote-helpers/test-hg.sh >>> b/contrib/remote-helpers/test-hg.sh >>> index 84c67ff..5eda265 100755 >>> --- a/contrib/remote-helpers/test-hg.sh >>> +++ b/contrib/remote-helpers/test-hg.sh >>> @@ -209,16 +209,16 @@ test_expect_success 'authors' ' >>> >>> >../expected && >>> author_test alpha "" "H G Wells " && >>> -author_test beta "test" "test " && >>> -author_test beta "test (comment)" "test >>> " && > > Notice the two betas here in the original code. Ahh, that's a bug. >>> -author_test gamma "" "Unknown " && >>> -author_test delta "name" "name " && >>> -author_test epsilon "name " >>> && >>> -author_test zeta " test " "test " && >>> -author_test eta "test < t...@example.com >" "test " >>> && >>> -author_test theta "test >t...@example.com>" "test " >>> && >>> -author_test iota "test < test example com>" "test >>> " && >>> -author_test kappa "t...@example.com" "Unknown " >>> +author_test beta "beta" "beta " && >>> +author_test beta "beta (comment)" "beta >>> " && >> >> Two betas? > > See above. I can change them to beta1 and beta2, or if you'd prefer I > can change them to beta and gamma and increment the subsequent entries. Yeah, I would prefer that in two patches, one that fixes the sequence, and the other one that changes the emails. If you don't have time for that the original patch is OK by me. The problem with the sequence can be fixed later. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
On 2013-11-11 06:42, Felipe Contreras wrote: > Richard Hansen wrote: >> It's hard to tell which author conversion test failed when the email >> addresses look similar. >> >> Signed-off-by: Richard Hansen >> --- >> contrib/remote-helpers/test-hg.sh | 20 ++-- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/contrib/remote-helpers/test-hg.sh >> b/contrib/remote-helpers/test-hg.sh >> index 84c67ff..5eda265 100755 >> --- a/contrib/remote-helpers/test-hg.sh >> +++ b/contrib/remote-helpers/test-hg.sh >> @@ -209,16 +209,16 @@ test_expect_success 'authors' ' >> >> >../expected && >> author_test alpha "" "H G Wells " && >> -author_test beta "test" "test " && >> -author_test beta "test (comment)" "test >> " && Notice the two betas here in the original code. >> -author_test gamma "" "Unknown " && >> -author_test delta "name" "name " && >> -author_test epsilon "name " >> && >> -author_test zeta " test " "test " && >> -author_test eta "test < t...@example.com >" "test " && >> -author_test theta "test >t...@example.com>" "test " && >> -author_test iota "test < test example com>" "test " >> && >> -author_test kappa "t...@example.com" "Unknown " >> +author_test beta "beta" "beta " && >> +author_test beta "beta (comment)" "beta >> " && > > Two betas? See above. I can change them to beta1 and beta2, or if you'd prefer I can change them to beta and gamma and increment the subsequent entries. Thanks, Richard > >> +author_test gamma "" "Unknown " && >> +author_test delta "delta" "delta " >> && >> +author_test epsilon "epsilon > " && >> +author_test zeta " zeta " "zeta " && >> +author_test eta "eta < t...@example.com >" "eta " && >> +author_test theta "theta >t...@example.com>" "theta " >> && >> +author_test iota "iota < test example com>" "iota " >> && >> +author_test kappa "ka...@example.com" "Unknown " >> ) && >> >> git clone "hg::hgrepo" gitrepo && > -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [PATCH 6/7] test-hg.sh: help user correlate verbose output with email test
Richard Hansen wrote: > It's hard to tell which author conversion test failed when the email > addresses look similar. > > Signed-off-by: Richard Hansen > --- > contrib/remote-helpers/test-hg.sh | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/contrib/remote-helpers/test-hg.sh > b/contrib/remote-helpers/test-hg.sh > index 84c67ff..5eda265 100755 > --- a/contrib/remote-helpers/test-hg.sh > +++ b/contrib/remote-helpers/test-hg.sh > @@ -209,16 +209,16 @@ test_expect_success 'authors' ' > > >../expected && > author_test alpha "" "H G Wells " && > - author_test beta "test" "test " && > - author_test beta "test (comment)" "test > " && > - author_test gamma "" "Unknown " && > - author_test delta "name" "name " && > - author_test epsilon "name " > && > - author_test zeta " test " "test " && > - author_test eta "test < t...@example.com >" "test " && > - author_test theta "test >t...@example.com>" "test " && > - author_test iota "test < test example com>" "test " > && > - author_test kappa "t...@example.com" "Unknown " > + author_test beta "beta" "beta " && > + author_test beta "beta (comment)" "beta > " && Two betas? > + author_test gamma "" "Unknown " && > + author_test delta "delta" "delta " > && > + author_test epsilon "epsilon " && > + author_test zeta " zeta " "zeta " && > + author_test eta "eta < t...@example.com >" "eta " && > + author_test theta "theta >t...@example.com>" "theta " > && > + author_test iota "iota < test example com>" "iota " > && > + author_test kappa "ka...@example.com" "Unknown " > ) && > > git clone "hg::hgrepo" gitrepo && -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
