Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()
Junio C Hamano gits...@pobox.com writes: The point immediately before it is about having SP after the control keyword. Follow it. Signed-off-by: Junio C Hamano gits...@pobox.com --- Documentation/CodingGuidelines | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 1b0cd2b..21e4272 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -184,7 +184,7 @@ For C programs: of else if statements, it can make sense to add braces to single line blocks. - - We try to avoid assignments inside if(). + - We try to avoid assignments inside if () condition. That's not grammatical. -- David Kastrup -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()
David Kastrup d...@gnu.org writes: - - We try to avoid assignments inside if(). + - We try to avoid assignments inside if () condition. That's not grammatical. OK, ... inside the condition part of an if () statement. then? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 6/8] CodingGuidelines: call the conditional statement if (), not if()
Junio C Hamano gits...@pobox.com writes: David Kastrup d...@gnu.org writes: - - We try to avoid assignments inside if(). + - We try to avoid assignments inside if () condition. That's not grammatical. OK, ... inside the condition part of an if () statement. then? ... in the condition of an if statement is what I would write. if () statement is mixing name and shorthand for the statement. -- David Kastrup -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
