Re: [PATCH 6/8] sh-setup: make die_with_status clear GIT_REFLOG_ACTION

2013-06-18 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Several callers set GIT_REFLOG_ACTION via set_reflog_action(), but nobody unsets it, leaving a potentially stray variable in the environment. Fix this by making die_with_status() unset it. I am totally lost. - You can set your own environment

Re: [PATCH 6/8] sh-setup: make die_with_status clear GIT_REFLOG_ACTION

2013-06-18 Thread Ramkumar Ramachandra
Junio C Hamano wrote: - There is no mechanism for you to affect environment of your parent process. Please excuse my stupidity and drop this patch. I got mislead by your SQUASH??? patch which took care to set the environment variable and call checkout in a subshell. -- To unsubscribe from

Re: [PATCH 6/8] sh-setup: make die_with_status clear GIT_REFLOG_ACTION

2013-06-18 Thread Junio C Hamano
Ramkumar Ramachandra artag...@gmail.com writes: Please excuse my stupidity and drop this patch. Heh, we always have brain-fart every once in a while. Your stupidity is always gladly excused ;-) I got mislead by your SQUASH??? patch which took care to set the environment variable and call