Re: [PATCH 9/9] remote-curl: reencode http error messages

2014-05-22 Thread Peter Krefting
Kyle J. McKay: + if (!*charset) + *charset = xstrdup("iso8859-1"); Actually the name should be "ISO-8859-1". See RFC 2616 section 3.7.1. Since it's case insensitive "iso-8859-1" would be fine too. You'd be amazed at what you see in the wild... I'd recommend going with

Re: [PATCH 9/9] remote-curl: reencode http error messages

2014-05-21 Thread Jeff King
On Wed, May 21, 2014 at 05:07:40PM -0700, Kyle J. McKay wrote: > >+/* default charset from rfc2616 */ > >+if (!*charset) > >+*charset = xstrdup("iso8859-1"); > > Actually the name should be "ISO-8859-1". See RFC 2616 section 3.7.1. > Since it's case insensitive "iso-8859-1" w

Re: [PATCH 9/9] remote-curl: reencode http error messages

2014-05-21 Thread Kyle J. McKay
On May 21, 2014, at 03:33, Jeff King wrote: As of the last commit, we now recognize an error message with a content-type "text/plain; charset=utf-16" as text, but we ignore the charset parameter entirely. Let's encode it to log_output_encoding, which is presumably something the user's terminal c