Re: [PATCH v1 2/2] submodule: port submodule subcommand 'deinit' from shell to C

2018-01-10 Thread Junio C Hamano
Prathamesh Chavan writes: > Thanks for pointing out that we can introduce the flag > REMOVE_DIR_KEEP_TOPLEVEL > which solves the issue. And for the case where no directory exists: we > create an empty > directory.Since this won't be similar to what happens in the shell >

Re: [PATCH v1 2/2] submodule: port submodule subcommand 'deinit' from shell to C

2018-01-10 Thread Prathamesh Chavan
On Wed, Jan 10, 2018 at 2:54 AM, Junio C Hamano wrote: > Prathamesh Chavan writes: > >> The same mechanism is used even for porting this submodule >> subcommand, as used in the ported subcommands till now. >> The function cmd_deinit in split up after porting

Re: [PATCH v1 2/2] submodule: port submodule subcommand 'deinit' from shell to C

2018-01-09 Thread Junio C Hamano
Prathamesh Chavan writes: > The same mechanism is used even for porting this submodule > subcommand, as used in the ported subcommands till now. > The function cmd_deinit in split up after porting into four > functions: module_deinit(), for_each_listed_submodule(), >