Re: [PATCH v1 22/45] archive: convert to use parse_pathspec

2013-03-17 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: No, the literal strings are reparsed in path_exists() before being fed to read_tree_recursive. Yuck. OK. Thanks. -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v1 22/45] archive: convert to use parse_pathspec

2013-03-16 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Sat, Mar 16, 2013 at 12:56 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: @@ -232,11 +228,18 @@ static int path_exists(struct tree *tree, const char *path) static void parse_pathspec_arg(const char

Re: [PATCH v1 22/45] archive: convert to use parse_pathspec

2013-03-15 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: @@ -232,11 +228,18 @@ static int path_exists(struct tree *tree, const char *path) static void parse_pathspec_arg(const char **pathspec, struct archiver_args *ar_args) { - ar_args-pathspec = pathspec = get_pathspec(,

Re: [PATCH v1 22/45] archive: convert to use parse_pathspec

2013-03-15 Thread Duy Nguyen
On Sat, Mar 16, 2013 at 12:56 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: @@ -232,11 +228,18 @@ static int path_exists(struct tree *tree, const char *path) static void parse_pathspec_arg(const char **pathspec, struct