Re: [PATCH v10 3/5] t4205, t6006, t7102: make functions better readable

2013-07-05 Thread Junio C Hamano 
Junio C Hamano  writes:

> Alexey Shumkin  writes:
>
>> -msg=$(printf "modify 2nd file (ge\303\244ndert)")
>> +msg="modify 2nd file (ge\303\244ndert)"
>>  if test -n "$1"
>>  then
>> -msg=$(echo $msg | iconv -f utf-8 -t $1)
>> +print "$msg" | iconv -f utf-8 -t "$1"
>> +else
>> +print "$msg"
>>  fi
>> -echo $msg
>>  }
>
> I think I'll do s/print/&f/ before queuing this.

Also, I'll change the $msg constant to have \n at the end, as we are
losing it by bypassing "echo".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v10 3/5] t4205, t6006, t7102: make functions better readable

2013-07-05 Thread Junio C Hamano 
Alexey Shumkin  writes:

> - msg=$(printf "modify 2nd file (ge\303\244ndert)")
> + msg="modify 2nd file (ge\303\244ndert)"
>   if test -n "$1"
>   then
> - msg=$(echo $msg | iconv -f utf-8 -t $1)
> + print "$msg" | iconv -f utf-8 -t "$1"
> + else
> + print "$msg"
>   fi
> - echo $msg
>  }

I think I'll do s/print/&f/ before queuing this.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html