Re: [PATCH v14 01/16] test: add test cases for relative_path

2013-06-25 Thread Jiang Xin
2013/6/25 Junio C Hamano gits...@pobox.com: Add prefix _ to workaround the absolute path rewritten issue in msysGit is interesting, but these test cases have already been tested in Linux, right? The most important thing is what we want to test in these tests. The special test program is to

Re: [PATCH v14 01/16] test: add test cases for relative_path

2013-06-24 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: diff --git a/test-path-utils.c b/test-path-utils.c index 0092cb..dcc530 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -28,6 +28,19 @@ static int normalize_ceiling_entry(struct string_list_item *item, void *unused) return 1; }

Re: [PATCH v14 01/16] test: add test cases for relative_path

2013-06-24 Thread Jiang Xin
2013/6/25 Junio C Hamano gits...@pobox.com: Jiang Xin worldhello@gmail.com writes: diff --git a/test-path-utils.c b/test-path-utils.c index 0092cb..dcc530 100644 --- a/test-path-utils.c +++ b/test-path-utils.c @@ -28,6 +28,19 @@ static int normalize_ceiling_entry(struct

Re: [PATCH v14 01/16] test: add test cases for relative_path

2013-06-24 Thread Junio C Hamano
Jiang Xin worldhello@gmail.com writes: In order to test NULL pointer in t/t0060, I have to write normalize_argv_string to convert null to NULL Yes, null and empty I already understand. Add prefix _ to workaround the absolute path rewritten issue in msysGit is interesting, but