Re: [PATCH v2] Document pack v4 format

2013-09-06 Thread Nicolas Pitre
On Fri, 6 Sep 2013, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 11:52 PM, Duy Nguyen wrote: > > On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: > >> Now the pack index v3 probably needs to be improved a little, again to > >> accommodate completion of thin packs. Given that the main SHA1 ta

Re: [PATCH v2] Document pack v4 format

2013-09-05 Thread Duy Nguyen
On Thu, Sep 5, 2013 at 11:52 PM, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: >> Now the pack index v3 probably needs to be improved a little, again to >> accommodate completion of thin packs. Given that the main SHA1 table is >> now in the main pack file, it should

Re: [PATCH v2] Document pack v4 format

2013-09-05 Thread Nicolas Pitre
On Thu, 5 Sep 2013, Junio C Hamano wrote: > Nicolas Pitre writes: > > > On Thu, 5 Sep 2013, Duy Nguyen wrote: > > > >> On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: > >> > Now the pack index v3 probably needs to be improved a little, again to > >> > accommodate completion of thin packs.

Re: [PATCH v2] Document pack v4 format

2013-09-05 Thread Junio C Hamano
Nicolas Pitre writes: > On Thu, 5 Sep 2013, Duy Nguyen wrote: > >> On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: >> > Now the pack index v3 probably needs to be improved a little, again to >> > accommodate completion of thin packs. Given that the main SHA1 table is >> > now in the main

Re: [PATCH v2] Document pack v4 format

2013-09-05 Thread Duy Nguyen
On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: > Now the pack index v3 probably needs to be improved a little, again to > accommodate completion of thin packs. Given that the main SHA1 table is > now in the main pack file, it should be possible to still carry a small > SHA1 table in the in

Re: [PATCH v2] Document pack v4 format

2013-09-05 Thread Nicolas Pitre
On Thu, 5 Sep 2013, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 12:39 PM, Nicolas Pitre wrote: > > Now the pack index v3 probably needs to be improved a little, again to > > accommodate completion of thin packs. Given that the main SHA1 table is > > now in the main pack file, it should be possibl

Re: [PATCH v2] Document pack v4 format

2013-09-04 Thread Nicolas Pitre
On Thu, 5 Sep 2013, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 11:40 AM, Nicolas Pitre wrote: > > On Thu, 5 Sep 2013, Duy Nguyen wrote: > > > >> On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre wrote: > >> > Many other bugs have now been fixed. A git.git repository with packs > >> > version 4 app

Re: [PATCH v2] Document pack v4 format

2013-09-04 Thread Duy Nguyen
On Thu, Sep 5, 2013 at 11:40 AM, Nicolas Pitre wrote: > On Thu, 5 Sep 2013, Duy Nguyen wrote: > >> On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre wrote: >> > Many other bugs have now been fixed. A git.git repository with packs >> > version 4 appears to be functional and passes git-fsck --full --

Re: [PATCH v2] Document pack v4 format

2013-09-04 Thread Nicolas Pitre
On Thu, 5 Sep 2013, Duy Nguyen wrote: > On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre wrote: > > Many other bugs have now been fixed. A git.git repository with packs > > version 4 appears to be functional and passes git-fsck --full --strict. > > Yeah I was looking at the diff some minutes ago,

Re: [PATCH v2] Document pack v4 format

2013-09-04 Thread Duy Nguyen
On Thu, Sep 5, 2013 at 11:12 AM, Nicolas Pitre wrote: > Many other bugs have now been fixed. A git.git repository with packs > version 4 appears to be functional and passes git-fsck --full --strict. Yeah I was looking at the diff some minutes ago, saw changes in pack-check.c and wondering if fsc

Re: [PATCH v2] Document pack v4 format

2013-09-04 Thread Nicolas Pitre
On Tue, 3 Sep 2013, Duy Nguyen wrote: > On Tue, Sep 3, 2013 at 6:49 PM, Duy Nguyen wrote: > > On Tue, Sep 3, 2013 at 1:46 PM, Nicolas Pitre wrote: > >> So... looks like pack v4 is now "functional". > >> > >> However something is still wrong as it operates about 6 times slower > >> than pack v3.

Re: [PATCH v2] Document pack v4 format

2013-09-03 Thread Duy Nguyen
On Tue, Sep 3, 2013 at 6:49 PM, Duy Nguyen wrote: > On Tue, Sep 3, 2013 at 1:46 PM, Nicolas Pitre wrote: >> So... looks like pack v4 is now "functional". >> >> However something is still wrong as it operates about 6 times slower >> than pack v3. >> >> Anyone wishes to investigate? > > You recurse

Re: [PATCH v2] Document pack v4 format

2013-09-03 Thread Duy Nguyen
On Tue, Sep 3, 2013 at 1:46 PM, Nicolas Pitre wrote: > So... looks like pack v4 is now "functional". > > However something is still wrong as it operates about 6 times slower > than pack v3. > > Anyone wishes to investigate? You recurse in decode_entries too deep.I check the first 1 decode_ent

Re: [PATCH v2] Document pack v4 format

2013-09-02 Thread Nicolas Pitre
On Tue, 3 Sep 2013, Nicolas Pitre wrote: > On Sat, 31 Aug 2013, Nguyễn Thái Ngọc Duy wrote: > > > > > Signed-off-by: Nguyễn Thái Ngọc Duy > > --- > > Incorporated suggestions by Nico and Junio. I went ahead and added > > escape hatches for converting thin packs to full ones so the document >

Re: [PATCH v2] Document pack v4 format

2013-09-02 Thread Nicolas Pitre
On Sat, 31 Aug 2013, Nguyễn Thái Ngọc Duy wrote: > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Incorporated suggestions by Nico and Junio. I went ahead and added > escape hatches for converting thin packs to full ones so the document > does not really match the code (I've been watching Nico