Jonathan Nieder writes:
> - /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not por...
> + /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is n...
I see you also tightened what the "variable" to be assigned should
look like, which is a good change to avoid false positives.
Beca
Torsten Bögershausen writes:
> I wonder if we could keep the anchoring (to reduce false positives)
> and try to catch a line "command1 && command2" at the same time:
Well, "command1 || command2" would be the next thing you want to
catch, and I think you are at the entrance of a slipperly slope a
On 2014-05-23 20.44, Jonathan Nieder wrote:
> Junio C Hamano wrote:
>> Elia Pinto writes:
>
>>> Found by check-non-portable-shell.pl
>>
>> Thanks.
>>
>> Makes me wonder why these two were missed, though.
>
> Good catch. check-non-portable-shell.pl uses an anchored regex:
>
> /^\s*export\
On Fri, May 23, 2014 at 6:15 AM, Elia Pinto wrote:
> Subject: Get rid of the non portable shell export VAR=VALUE costruct
s/costruct/construct/
s/non portable/non-portable/
> Found by check-non-portable-shell.pl
>
> Signed-off-by: Elia Pinto
> ---
> This is the second version of the patch that
Hi,
Junio C Hamano wrote:
> Junio C Hamano writes:
>> Makes me wonder why these two were missed, though.
>
> Perhaps something like this?
[...]
> - /^\s*export\s+[^=]*=/ and err '"export FOO=bar" is not portable (please
> use FOO=bar && export FOO)';
> + /(?:^|[^-a-zA-Z0-9_])export\s+[^
Junio C Hamano wrote:
> Elia Pinto writes:
>> Found by check-non-portable-shell.pl
>
> Thanks.
>
> Makes me wonder why these two were missed, though.
Good catch. check-non-portable-shell.pl uses an anchored regex:
/^\s*export\s+[^=]*=/
Perhaps something like
/\bexport\s+[A-Za
Junio C Hamano writes:
> Elia Pinto writes:
>
>> Found by check-non-portable-shell.pl
>
> Thanks.
>
> Makes me wonder why these two were missed, though.
Perhaps something like this?
I didn't check other rules, though, because I still have a feeling
that this "pretend to understand the shell sy
Elia Pinto writes:
> Found by check-non-portable-shell.pl
Thanks.
Makes me wonder why these two were missed, though.
t/t3032-merge-recursive-options.sh | 6 +-
t/t5560-http-backend-noserver.sh | 6 +-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/t/t3032-merge-rec
Elia Pinto wrote:
> Signed-off-by: Elia Pinto
> ---
> contrib/subtree/t/t7900-subtree.sh |3 ++-
> git-remote-testgit.sh |3 ++-
> git-stash.sh |3 ++-
> 3 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Jonathan Nieder
--
To unsubscri
9 matches
Mail list logo
