Re: [PATCH v2] branch.c: change install_branch_config() to use skip_prefix()

2014-03-03 Thread Junio C Hamano
Eric Sunshine writes: >> diff --git a/branch.c b/branch.c >> index 723a36b..ca4e824 100644 >> --- a/branch.c >> +++ b/branch.c >> @@ -50,7 +50,7 @@ static int should_setup_rebase(const char *origin) >> void install_branch_config(int flag, const char *local, const char *origin, >> const char *re

Re: [PATCH v2] branch.c: change install_branch_config() to use skip_prefix()

2014-03-02 Thread Guanglin Xu
2014-03-03 6:56 GMT+08:00 Eric Sunshine : > Thanks for the submission. Comments below to give you a taste of the > Git review process... > > On Sun, Mar 2, 2014 at 10:55 AM, Guanglin Xu wrote: >> Change install_branch_config() to use skip_prefix() and make it conform to >> the usage of previous s

Re: [PATCH v2] branch.c: change install_branch_config() to use skip_prefix()

2014-03-02 Thread Eric Sunshine
Thanks for the submission. Comments below to give you a taste of the Git review process... On Sun, Mar 2, 2014 at 10:55 AM, Guanglin Xu wrote: > Change install_branch_config() to use skip_prefix() and make it conform to > the usage of previous starts_with(). This is because the proper usage of