Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-16 Thread John Keeping
On Mon, Aug 15, 2016 at 09:40:54PM +0100, Philip Oakley wrote: > From: "Junio C Hamano" > > "Philip Oakley" writes: > > > >> I'm still not sure this is enough. One of the problems back when I > >> introduced the --guides option (65f9835 (builtin/help.c:

Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-15 Thread Junio C Hamano
"Philip Oakley" writes: > The other option is to simply build a guide-list in exactly the same > format as the command list (which if it works can be merged > later). Re-use the existing code, etc. Yeah, that sounds like a good way to go forward. To implement typo

Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-15 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: I'm still not sure this is enough. One of the problems back when I introduced the --guides option (65f9835 (builtin/help.c: add --guide option, 2013-04-02)) was that we had no easy way of determining what

Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-15 Thread Junio C Hamano
"Philip Oakley" writes: > I'm still not sure this is enough. One of the problems back when I > introduced the --guides option (65f9835 (builtin/help.c: add --guide > option, 2013-04-02)) was that we had no easy way of determining what > guides were available, especially

Re: [PATCH v2] help: make option --help open man pages only for Git commands

2016-08-15 Thread Philip Oakley
From: "Ralf Thielow" If option --help is passed to a Git command, we try to open the man page of that command. However, we do it even for commands we don't know. Make sure the command is known to Git before try to open the man page. If we don't know the command, give