Re: [PATCH v2] ls-files: adding support for submodules

2016-09-15 Thread Junio C Hamano
Junio C Hamano writes: > Thanks, will queue with a minimum fix. So here are two squashable patches, one is the "minimum" one, the other is a bit more invasive one to use "a pointer to an optional setting is set to NULL" convention. I am undecided, and I'll stay to be without further comments fr

Re: [PATCH v2] ls-files: adding support for submodules

2016-09-15 Thread Junio C Hamano
If we were to follow the convention to leave an optional string variable to NULL, we'd need to do this on top. I am not sure if it is a good change, though. --- builtin/ls-files.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/builtin/ls-files.c b/builtin/ls-files.c in

Re: [PATCH v2] ls-files: adding support for submodules

2016-09-15 Thread Junio C Hamano
Here is an absolute mininum fix ;-) builtin/ls-files.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/ls-files.c b/builtin/ls-files.c index c0bce00..6e78c71 100644 --- a/builtin/ls-files.c +++ b/builtin/ls-files.c @@ -78,7 +78,7 @@ static void write_name(const char *n

Re: [PATCH v2] ls-files: adding support for submodules

2016-09-15 Thread Junio C Hamano
Junio C Hamano writes: > Thanks, will queue with a minimum fix. So here are two squashable patches, one is the "minimum" one, the other is a bit more invasive one to use "a pointer to an optional setting is set to NULL" convention. I am undecided, and I'll stay to be without further comments fr

Re: [PATCH v2] ls-files: adding support for submodules

2016-09-13 Thread Junio C Hamano
Brandon Williams writes: > Allow ls-files to recognize submodules in order to retrieve a list of > files from a repository's submodules. This is done by forking off a > process to recursively call ls-files on all submodules. Also added an > output-path-prefix command in order to prepend paths to

Re: [PATCH v2] ls-files: adding support for submodules

2016-09-12 Thread Brandon Williams
> static void write_name(const char *name) > { > /* > +* NEEDSWORK: To make this thread-safe, full_name would have to be > owned > +* by the caller. > +* > +* full_name get reused across output lines to minimize the allocation > +* churn. > +