Re: [PATCH v2] rebase -i: replace an echo command by printf

2014-03-17 Thread Uwe Storbeck
On Mar 17, Junio C Hamano wrote: > Will tentatively queue with the above rewrite, but if you feel > strongly, please send an replacement. No need for a replacement, your wording is good. I couldn't do it better. I'll borrow your commit message for my other patch to fix the continued title there t

Re: [PATCH v2] rebase -i: replace an echo command by printf

2014-03-17 Thread Junio C Hamano
Uwe Storbeck writes: > to avoid shell dependent behavior. Please do not start the body of the log message half-sentence. The title ought to be a freestanding "title", not just a beginning half of a sentence that needs to be read with the rest to be understood. Something like this, perhaps.