Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

2018-06-04 Thread Junio C Hamano
"Robert P. J. Day" writes: > one thing i don't see there, and it's based on an observation someone > once made (i believe on this list), is that even if there is > absolutely no ambiguity in a command, even if there are no pathspec > arguments, it's still worthwhile to add a trailing "--": > >

Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

2018-06-04 Thread Robert P. J. Day
On Sun, 3 Jun 2018, Philip Oakley wrote: > From: "Robert P. J. Day" > > On Sun, 3 Jun 2018, Thomas Gummerer wrote: > >> --get-regex works as the parse-option API allows abbreviations of > >> the full option to be specified as long as the abbreviation is > >> unambiguos. I don't know if this is

Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

2018-06-03 Thread Philip Oakley
From: "Robert P. J. Day" On Sun, 3 Jun 2018, Thomas Gummerer wrote: > Subject: [PATCH v2] t/perf/run: Use proper "--get-regexp", not micronit: we prefer starting with a lowercase letter after the "area:" prefix in commit messages. Junio can probably fix that while queuing, so no need to

Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

2018-06-03 Thread Robert P. J. Day
On Sun, 3 Jun 2018, Thomas Gummerer wrote: > > Subject: [PATCH v2] t/perf/run: Use proper "--get-regexp", not > > micronit: we prefer starting with a lowercase letter after the "area:" > prefix in commit messages. Junio can probably fix that while > queuing, so no need to resend. argh, i

Re: [PATCH v2] t/perf/run: Use proper "--get-regexp", not "--get-regex"

2018-06-03 Thread Thomas Gummerer
> Subject: [PATCH v2] t/perf/run: Use proper "--get-regexp", not micronit: we prefer starting with a lowercase letter after the "area:" prefix in commit messages. Junio can probably fix that while queuing, so no need to resend. On 06/03, Robert P. J. Day wrote: > > Even though "--get-regex"