Re: [PATCH v2 0/2] de-confuse git cherry-pick --author

2018-07-11 Thread Junio C Hamano
Johannes Schindelin writes: >> After poking at it a bit more, I've convinced myself that this is the >> right thing, as options like "--branches" which expand into multiple >> tips already push us into the other code path. >> >> So here's a re-roll. The first one is identical except for the typo

Re: [PATCH v2 0/2] de-confuse git cherry-pick --author

2018-07-11 Thread Johannes Schindelin
Hi Peff, On Tue, 10 Jul 2018, Jeff King wrote: > On Mon, Jul 09, 2018 at 10:15:05PM -0400, Jeff King wrote: > > > > Should this not rather be > > > > > > - if (!cmit || get_revision(opts->revs)) > > > - return error("BUG: expected exactly one commit from > > > walk"); >