Re: [PATCH v2 0/3] Fix a race condition when reading loose refs

2013-06-19 Thread Jeff King
On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:

 I took Peff's suggestion to use gotos rather than an infinite loop in
 the last patch, which means that there is no need for the old patch
 03/04.

Thanks, this version looks good to me.

I'm sure the Pascal programmers of the world collectively sighed in
disgust at a code review requesting a for loop turn into a goto, but I
think it is more readable than the first version. :)

-Peff
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2 0/3] Fix a race condition when reading loose refs

2013-06-19 Thread Junio C Hamano
Jeff King p...@peff.net writes:

 On Wed, Jun 19, 2013 at 08:36:25AM +0200, Michael Haggerty wrote:

 I took Peff's suggestion to use gotos rather than an infinite loop in
 the last patch, which means that there is no need for the old patch
 03/04.

 Thanks, this version looks good to me.

 I'm sure the Pascal programmers of the world collectively sighed in
 disgust at a code review requesting a for loop turn into a goto, but I
 think it is more readable than the first version. :)

 -Peff

Thanks, both.  Essentially the first two are the same from the
previous round, and the third one gives us oops, unexpected
state---let's retry in a more straight-forward way.

Looks very sensible; will queue.
--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html