Re: [PATCH v2 0/9] add --gpg-sign to rebase and pull

2014-01-24 Thread Nicolas Vigier 
On Fri, 24 Jan 2014, brian m. carlson wrote:

 This series was posted to the list some time back, but it fell through
 the cracks.  This is a re-send of Nicolas Vigier's work with an
 additional patch that adds --gpg-sign to pull as well.  I added my
 sign-off to his patches because SubmittingPatches (section (c)) seems to
 imply that I should, although I can rebase it out if it's a problem.

Thanks!

An improvement I was thinking to do on this series but had not time to
do yet is to make the '--no-gpg-sign' option disable gpg signing when
the commit.gpgsign config option is set to true.

This would fix the problem mentioned about commit.gpgsign in What's
cooking in git.git that the variable cannot be overriden from the
command line of some of the commands that create commits.

Nicolas

--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/9] add --gpg-sign to rebase and pull

2014-01-24 Thread Junio C Hamano 
Nicolas Vigier bo...@mars-attacks.org writes:

 On Fri, 24 Jan 2014, brian m. carlson wrote:

 This series was posted to the list some time back, but it fell through
 the cracks.  This is a re-send of Nicolas Vigier's work with an
 additional patch that adds --gpg-sign to pull as well.  I added my
 sign-off to his patches because SubmittingPatches (section (c)) seems to
 imply that I should, although I can rebase it out if it's a problem.

 Thanks!

 An improvement I was thinking to do on this series but had not time to
 do yet is to make the '--no-gpg-sign' option disable gpg signing when
 the commit.gpgsign config option is set to true.

By the way, a configuration variable that has no way of getting
overriden per invocation should not exist without a very good reason
(core.bare is an example of a exception with a good reason---the
bareness of the repository does not change per command invocation).
An escape hatch --no-gpg-sign is a must-have requirement, not a
nice-to-have improvement.

Thanks for not forgetting.



--
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html