Re: [PATCH v2 00/11] Use ALLOC_GROW() instead of inline code
Michael Haggerty writes: > On 02/28/2014 10:29 AM, Dmitry S. Dolzhenko wrote: >> Thank you for your remarks. In this patch I tried to take them into account. >> >> Dmitry S. Dolzhenko (11): >> builtin/pack-objects.c: change check_pbase_path() to use ALLOC_GROW() >> bundle.c: change add_to_ref_list() to use ALLOC_GROW() >> cache-tree.c: change find_subtree() to use ALLOC_GROW() >> commit.c: change register_commit_graft() to use ALLOC_GROW() >> diff.c: use ALLOC_GROW() instead of inline code >> diffcore-rename.c: use ALLOC_GROW() instead of inline code >> patch-ids.c: change add_commit() to use ALLOC_GROW() >> replace_object.c: change register_replace_object() to use ALLOC_GROW() >> reflog-walk.c: use ALLOC_GROW() instead of inline code >> dir.c: change create_simplify() to use ALLOC_GROW() >> attr.c: change handle_attr_line() to use ALLOC_GROW() >> >> attr.c | 7 +-- >> builtin/pack-objects.c | 7 +-- >> bundle.c | 6 +- >> cache-tree.c | 6 +- >> commit.c | 8 ++-- >> diff.c | 12 ++-- >> diffcore-rename.c | 12 ++-- >> dir.c | 5 + >> patch-ids.c| 5 + >> reflog-walk.c | 13 +++-- >> replace_object.c | 8 ++-- >> 11 files changed, 17 insertions(+), 72 deletions(-) > > Everything looks fine to me. Assuming the test suite ran 100%, > > Acked-by: Michael Haggerty Looked good (modulo titles, which I think we already discussed), and queued on 'pu'. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/11] Use ALLOC_GROW() instead of inline code
Michael, On 28.02.2014 18:38, Michael Haggerty wrote: > Everything looks fine to me. Assuming the test suite ran 100%, > > Acked-by: Michael Haggerty All tests passed successfully for this patch, at least on my machine. Can I do something else to improve this patch? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v2 00/11] Use ALLOC_GROW() instead of inline code
On 02/28/2014 10:29 AM, Dmitry S. Dolzhenko wrote: > Thank you for your remarks. In this patch I tried to take them into account. > > Dmitry S. Dolzhenko (11): > builtin/pack-objects.c: change check_pbase_path() to use ALLOC_GROW() > bundle.c: change add_to_ref_list() to use ALLOC_GROW() > cache-tree.c: change find_subtree() to use ALLOC_GROW() > commit.c: change register_commit_graft() to use ALLOC_GROW() > diff.c: use ALLOC_GROW() instead of inline code > diffcore-rename.c: use ALLOC_GROW() instead of inline code > patch-ids.c: change add_commit() to use ALLOC_GROW() > replace_object.c: change register_replace_object() to use ALLOC_GROW() > reflog-walk.c: use ALLOC_GROW() instead of inline code > dir.c: change create_simplify() to use ALLOC_GROW() > attr.c: change handle_attr_line() to use ALLOC_GROW() > > attr.c | 7 +-- > builtin/pack-objects.c | 7 +-- > bundle.c | 6 +- > cache-tree.c | 6 +- > commit.c | 8 ++-- > diff.c | 12 ++-- > diffcore-rename.c | 12 ++-- > dir.c | 5 + > patch-ids.c| 5 + > reflog-walk.c | 13 +++-- > replace_object.c | 8 ++-- > 11 files changed, 17 insertions(+), 72 deletions(-) Everything looks fine to me. Assuming the test suite ran 100%, Acked-by: Michael Haggerty Thanks! Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
