Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-18 Thread Jonathan Tan
On Fri, 11 Aug 2017 15:41:28 -0400 Ben Peart wrote: > Nice to see the pack file functions being refactored out. I looked at > the end result and it looked good to me. Thanks. > Do you have the energy to do a similar refactoring for the remaining > public functions residing in sha1_file.c? P

Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-11 Thread Ben Peart
On 8/8/2017 9:22 PM, Jonathan Tan wrote: Here is the complete patch set. I have only moved the exported functions that operate with packfiles and their static helpers - for example, static functions like freshen_packed_object() that are used only by non-pack-specific functions are not moved. I

Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-10 Thread Junio C Hamano
Jonathan Tan writes: > On Thu, 10 Aug 2017 14:19:59 -0700 > Junio C Hamano wrote: > >> Jonathan Tan writes: >> >> > Here is the complete patch set. I have only moved the exported functions >> > that operate with packfiles and their static helpers - for example, >> > static functions like fresh

Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-10 Thread Jonathan Tan
On Thu, 10 Aug 2017 14:19:59 -0700 Junio C Hamano wrote: > Jonathan Tan writes: > > > Here is the complete patch set. I have only moved the exported functions > > that operate with packfiles and their static helpers - for example, > > static functions like freshen_packed_object() that are used

Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-10 Thread Junio C Hamano
Jonathan Tan writes: > Here is the complete patch set. I have only moved the exported functions > that operate with packfiles and their static helpers - for example, > static functions like freshen_packed_object() that are used only by > non-pack-specific functions are not moved. This will inter

Re: [PATCH v2 00/25] Move exported packfile funcs to its own file

2017-08-10 Thread Stefan Beller
On Tue, Aug 8, 2017 at 6:22 PM, Jonathan Tan wrote: > Here is the complete patch set. I have only moved the exported functions > that operate with packfiles and their static helpers - for example, > static functions like freshen_packed_object() that are used only by > non-pack-specific functions a