Re: [PATCH v2 05/38] refs: create a base class "ref_store" for files_ref_store

2016-09-05 Thread David Turner
On Mon, 2016-09-05 at 05:53 +0200, Michael Haggerty wrote: > On 09/04/2016 10:40 PM, David Turner wrote: > > On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: > > > >> +/* A linked list of ref_stores for submodules: */ > >> +static struct ref_store *submodule_ref_stores; > > > > I don't

Re: [PATCH v2 05/38] refs: create a base class "ref_store" for files_ref_store

2016-09-04 Thread Stefan Beller
On 04.09.2016 20:53, Michael Haggerty wrote: > On 09/04/2016 10:40 PM, David Turner wrote: >> On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: >> >>> +/* A linked list of ref_stores for submodules: */ >>> +static struct ref_store *submodule_ref_stores; >> >> I don't like the per-submodule

Re: [PATCH v2 05/38] refs: create a base class "ref_store" for files_ref_store

2016-09-04 Thread Michael Haggerty
On 09/04/2016 10:40 PM, David Turner wrote: > On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: > >> +/* A linked list of ref_stores for submodules: */ >> +static struct ref_store *submodule_ref_stores; > > I don't like the per-submodule stores being in a linked list, which > requires a

Re: [PATCH v2 05/38] refs: create a base class "ref_store" for files_ref_store

2016-09-04 Thread David Turner
On Sun, 2016-09-04 at 18:08 +0200, Michael Haggerty wrote: > +/* A linked list of ref_stores for submodules: */ > +static struct ref_store *submodule_ref_stores; I don't like the per-submodule stores being in a linked list, which requires a linear search. Stefan has, I think, been doing a bunch