Re: [PATCH v2 09/12] pretty: add %C(auto) for auto-coloring on the next placeholder

2013-04-15 Thread Duy Nguyen
On Sat, Apr 6, 2013 at 4:13 AM, Junio C Hamano wrote: > If %C(auto) applies to some % but not to some others, > the user needs to learn which % will eat the "auto" (so > it no longer applies to the next one) and which one will not even > look at "auto" (so the next % is affected by the auto, > i.e

Re: [PATCH v2 09/12] pretty: add %C(auto) for auto-coloring on the next placeholder

2013-04-05 Thread Junio C Hamano
Duy Nguyen writes: > The above should have written "will turn on auto coloring on the > following _textual_ placeholder". I didn't intend %C(auto) to be > followed by %C(color) as it's already covered by %C(auto,red). But of > course we could make it work too. You are right that there is no need

Re: [PATCH v2 09/12] pretty: add %C(auto) for auto-coloring on the next placeholder

2013-04-04 Thread Duy Nguyen
On Tue, Apr 2, 2013 at 5:26 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This is not simply convenient over %C(auto,xxx). Some placeholders >> (actually only one, %d) do multi coloring and we can't emit a multiple >> colors with %C(auto,xxx). >> >> Signed-off-by: Nguyễn Thái Ngọ

Re: [PATCH v2 09/12] pretty: add %C(auto) for auto-coloring on the next placeholder

2013-04-01 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This is not simply convenient over %C(auto,xxx). Some placeholders > (actually only one, %d) do multi coloring and we can't emit a multiple > colors with %C(auto,xxx). > > Signed-off-by: Nguyễn Thái Ngọc Duy > --- > Documentation/pretty-formats.txt | 3 ++- > pr