Josh Triplett writes:
> I didn't realize you had already taken the patch series into next; I'd
> assumed from the various comments that you expected me to reroll it
> before you'd take it.
>
> Would you like me to write something up for the release notes regarding
> plans
On Sun, Aug 07, 2016 at 07:02:18PM -1000, Josh Triplett wrote:
> > Portability; some compilers choke on it. C89 allows trailing commas in
> > array initialization but _not_ in enums. Most compilers allow it anyway
> > (though gcc complains with -Wpedantic).
> >
> > This definitely broke the
On Mon, Aug 08, 2016 at 12:54:41AM -0400, Jeff King wrote:
> On Sun, Aug 07, 2016 at 06:42:07PM -1000, Josh Triplett wrote:
>
> > > Drop trailing comma after the last enum definition (trailing comma
> > > after the last element in an array is OK, though).
> >
> > I realize this code didn't get
On Sun, Aug 07, 2016 at 06:42:07PM -1000, Josh Triplett wrote:
> > Drop trailing comma after the last enum definition (trailing comma
> > after the last element in an array is OK, though).
>
> I realize this code didn't get included in the final version, but for
> future reference, what's the
On Mon, Aug 01, 2016 at 02:18:47PM -0700, Junio C Hamano wrote:
> Josh Triplett writes:
> > +enum from {
> > + FROM_AUTHOR,
> > + FROM_USER,
> > + FROM_VALUE,
>
> Drop trailing comma after the last enum definition (trailing comma
> after the last element in an array
On Sun, Aug 07, 2016 at 06:59:09PM -0700, Junio C Hamano wrote:
> Josh Triplett writes:
>
> > I'd actually seriously considered this exact approach, which I preferred
> > as well, but I'd discarded it because I figured it'd get rejected.
> > Given your suggestion, and
Josh Triplett writes:
> I'd actually seriously considered this exact approach, which I preferred
> as well, but I'd discarded it because I figured it'd get rejected.
> Given your suggestion, and Junio's comment, I'll go with this version.
Sorry, but your response is soo
On Mon, Aug 01, 2016 at 01:38:47PM -0400, Jeff King wrote:
> On Sat, Jul 30, 2016 at 12:11:11PM -0700, Josh Triplett wrote:
>
> > +enum from {
> > + FROM_AUTHOR,
> > + FROM_USER,
> > + FROM_VALUE,
> > +};
> > +
> > +static void set_from(enum from type, const char *value)
> > +{
> > +
Josh Triplett writes:
> Subject: Re: [PATCH v2 1/2] format-patch: Add a config option format.from ...
At least s/Add/add/; but I would prefer an even shorter
format-patch: format.from gives the default for --from
> +static char *from;
The same "this does not
On Sat, Jul 30, 2016 at 12:11:11PM -0700, Josh Triplett wrote:
> +enum from {
> + FROM_AUTHOR,
> + FROM_USER,
> + FROM_VALUE,
> +};
> +
> +static void set_from(enum from type, const char *value)
> +{
> + free(from);
> + switch (type) {
> + case FROM_AUTHOR:
> +
10 matches
Mail list logo