Re: [PATCH v2 1/2] t5100-mailinfo: replace common path prefix with variable

2016-09-19 Thread Jeff King
On Mon, Sep 19, 2016 at 02:16:23PM -0700, Junio C Hamano wrote: > Kevin Daudt writes: > > > Many tests need to store data in a file, and repeat the same pattern to > > refer to that path: > > > > "$TEST_DATA"/t5100/ > > That obviously is a typo of > > "$TEST_DIRECTORY/t5100" > > It

Re: [PATCH v2 1/2] t5100-mailinfo: replace common path prefix with variable

2016-09-19 Thread Junio C Hamano
Kevin Daudt writes: > Many tests need to store data in a file, and repeat the same pattern to > refer to that path: > > "$TEST_DATA"/t5100/ That obviously is a typo of "$TEST_DIRECTORY/t5100" It is a good change, even though I would have chosen a name that is a bit more descriptive