Re: [PATCH v2 1/3] am: add --show-current-patch

2018-02-02 Thread Junio C Hamano
Duy Nguyen writes: > Subject: [PATCH] Preserve errno in case case before calling sth_errno() > > All these locations do something like this > > sth_errno(..., somefunc(...)); > > where somefunc() can potentially change errno, which will be read by > sth_errno(). Call

Re: [PATCH v2 1/3] am: add --show-current-patch

2018-02-02 Thread Duy Nguyen
On Fri, Feb 2, 2018 at 4:46 PM, Eric Sunshine wrote: > On Fri, Feb 2, 2018 at 4:25 AM, Duy Nguyen wrote: >> On Wed, Jan 31, 2018 at 02:59:32PM -0800, Junio C Hamano wrote: >>> Eric Sunshine writes: >>> > On Wed, Jan 31, 2018

Re: [PATCH v2 1/3] am: add --show-current-patch

2018-02-02 Thread Eric Sunshine
On Fri, Feb 2, 2018 at 4:25 AM, Duy Nguyen wrote: > On Wed, Jan 31, 2018 at 02:59:32PM -0800, Junio C Hamano wrote: >> Eric Sunshine writes: >> > On Wed, Jan 31, 2018 at 4:30 AM, Nguyễn Thái Ngọc Duy >> > wrote: >> >> + len =

Re: [PATCH v2 1/3] am: add --show-current-patch

2018-02-02 Thread Duy Nguyen
On Wed, Jan 31, 2018 at 02:59:32PM -0800, Junio C Hamano wrote: > Eric Sunshine writes: > > > On Wed, Jan 31, 2018 at 4:30 AM, Nguyễn Thái Ngọc Duy > > wrote: > >> Pointing the user to $GIT_DIR/rebase-apply may encourage them to mess > >> around in

Re: [PATCH v2 1/3] am: add --show-current-patch

2018-01-31 Thread Junio C Hamano
Eric Sunshine writes: > On Wed, Jan 31, 2018 at 4:30 AM, Nguyễn Thái Ngọc Duy > wrote: >> Pointing the user to $GIT_DIR/rebase-apply may encourage them to mess >> around in there, which is not a good thing. With this, the user does >> not have to

Re: [PATCH v2 1/3] am: add --show-current-patch

2018-01-31 Thread Eric Sunshine
On Wed, Jan 31, 2018 at 4:30 AM, Nguyễn Thái Ngọc Duy wrote: > Pointing the user to $GIT_DIR/rebase-apply may encourage them to mess > around in there, which is not a good thing. With this, the user does > not have to keep the path around somewhere (because after a couple of >